ascheman commented on issue #13084: URL: https://github.com/apache/maven/issues/13084#issuecomment-5652392324
@slachiewicz @gnodet > would you be able to create regression test? Done — a regression test for the **Maven 4 `impl` model builder**. #13095 fixes the negated-property profile filtering in both the compat and the impl builders, but adds a test only for the compat path (`maven-model-builder`); this covers the impl path (`maven-impl`). Cherry-pick branch, sitting directly on #13095's head: [`aschemaven/maven:bugfix/13084-impl-negated-profile-test`](https://github.com/aschemaven/maven/tree/bugfix/13084-impl-negated-profile-test) (single commit `d9c6ca2`). It builds a repository-resolved model (`CONSUMER_DEPENDENCY`) whose dependency POM carries a negated-property profile (`!skip.defaults`, default-on) plus a positive one, and asserts: - the negated-property profile stays active — its property and its injected dependency survive; this is the assertion that fails without the fix (`expected <activated> but was <null>`); - a repository declared *inside* that surviving profile is still stripped, so the activation carve-out does not reopen the repository-injection vector; - the positive-property profile stays filtered. @gnodet — easiest is to cherry-pick the single commit onto #13095 so fix + test land together; I can also open it as a stacked PR. Happy to help port tests to the other affected lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
