gnodet-bot commented on code in PR #13094:
URL: https://github.com/apache/maven/pull/13094#discussion_r4003075885
##########
impl/maven-core/src/main/java/org/apache/maven/DefaultMaven.java:
##########
@@ -348,8 +349,14 @@ private void setupWorkspaceReader(MavenSession session,
MavenChainedWorkspaceRea
workspaceReaders.add(repoWorkspaceReader);
}
}
- // 3) .. n) Project-scoped workspace readers
+ // 3) .. n) Project-scoped legacy workspace readers
(org.eclipse.aether)
workspaceReaders.addAll(getProjectScopedExtensionComponents(session.getProjects(),
WorkspaceReader.class));
+ // n+1) SPI workspace readers (org.apache.maven.api.spi) — discovered
here, after buildGraph()
+ // has loaded core extensions into the container so they are
visible via lookupList.
Review Comment:
💡 **Not addressed from previous review** — this comment still says "visible
via lookupList" but the code uses `getProjectScopedExtensionComponents()`.
Raised in the previous review at `8850b59ed8`.
```suggestion
// n+1) SPI workspace readers (org.apache.maven.api.spi) —
discovered here, after buildGraph()
// has loaded core extensions into the container so they are
visible via getProjectScopedExtensionComponents.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
