goutamadwant opened a new pull request, #534:
URL: https://github.com/apache/maven-build-cache-extension/pull/534
Fixes #407.
For `app -> bridge -> leaf-SNAPSHOT`, changing `leaf` can leave the
reproducible `bridge` JAR byte-identical. The application checksum currently
includes only declared mutable dependencies, so a clean application build can
restore stale compiled constants from cache.
Collect Maven's mediated dependency graph before cache lookup and hash
additional external SNAPSHOT artifacts. Use project checksums for transitive
reactor inputs. If graph resolution is unavailable, skip cache restoration and
saving, then let normal Maven execution enforce dependency requirements.
The integration tests cover SNAPSHOT and release bridges, unchanged-input
cache hits, exclusions, dependency management, transitive reactor inputs, and
offline `validate`. Both bridge cases fail on unchanged master (`8bec537`);
their fixed cached outputs match uncached rebuilds. Graph collection happens
before lookup; only additional external SNAPSHOT artifacts are resolved.
Validation on JDK 17:
- `mvn -Prun-its verify javadoc:jar`: passed with Maven 3.9.16. The run
reported 97 unit tests and 354 integration tests, with zero failures or errors.
Four schema-dependent unit tests and one macOS permission test were skipped.
- `mvn -Prun-its,maven3.10 -Dtest='MavenProjectInput*'
-Dit.test=TransitiveSnapshotTest verify`: passed with Maven 3.10.0-rc-1 for the
integration builds.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [ ] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
This change uses integration tests against Maven's real dependency
resolver.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
