olamy commented on code in PR #534:
URL:
https://github.com/apache/maven-build-cache-extension/pull/534#discussion_r4013623561
##########
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##########
@@ -199,7 +200,14 @@ public CacheResult findCachedBuild(
String projectName = getVersionlessProjectKey(project);
- ProjectsInputInfo inputInfo =
projectInputCalculator.calculateInput(project);
+ final ProjectsInputInfo inputInfo;
+ try {
+ inputInfo = projectInputCalculator.calculateInput(project);
+ } catch (DependencyGraphResolutionException e) {
+ LOGGER.warn("Skipping build cache for {}: {}", projectName,
e.getMessage());
Review Comment:
Well, if any remote repositories check for snapshots, we will now skip a
module that has not been restored or saved. Caching is becoming subject to
remote repo availability; this sounds fragile to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
