gnodet-bot commented on PR #13136:
URL: https://github.com/apache/maven/pull/13136#issuecomment-5682599917
Thanks @rmannibucau for the fix — the sorting approach is the right
direction.
One issue remains in the latest commit: modules with `buildSummary == null`
(i.e. modules that were never built because the build was aborted after a
failure upstream) are still silently suppressed when `hasExceptions()` is true:
```java
if (group == 0 && entry.buildSummary() == null && request.hasExceptions()) {
lastWasSkipped = true;
continue; // ← these modules disappear from the summary
}
```
This means the reactor summary is still incomplete on failure — just for a
different category of modules than before. Users with a 100-module project
where 80 built successfully and 19 were never reached won't see those 19 in the
summary at all, which is exactly the confusion #13135 describes.
The fix is simply to remove those three lines. With group-based sorting,
`buildSummary == null` modules land in group 0 (SKIPPED), appear first, and
failures still end up at the bottom where the terminal cursor sits. No need to
hide anything.
Also, the `detailLogger` split adds complexity without clear benefit — the
core value of this PR is the sorting, not the logger separation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
