gnodet-bot commented on code in PR #13136:
URL: https://github.com/apache/maven/pull/13136#discussion_r4017422048
##########
impl/maven-cli/src/main/java/org/apache/maven/cling/event/ExecutionEventLogger.java:
##########
@@ -237,11 +269,11 @@ private void logReactorSummary(MavenSession session) {
Review Comment:
This block silently suppresses modules that were never built (`buildSummary
== null`), which is the same incompleteness that #13135 was trying to fix —
just for a different category of modules. With the group-based sorting, these
modules already land in group 0 and display as SKIPPED before the successes and
failures. There's no reason to hide them.
Dropping these 4 lines gives a complete summary on failure: SKIPPED (not
built) → SUCCESS → FAILURE, with failures always last where the terminal cursor
sits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
