slachiewicz commented on issue #301:
URL:
https://github.com/apache/maven-dependency-analyzer/issues/301#issuecomment-5742850701
Closing: the root cause stated here is wrong, and the downstream IT failure
is the 1.17.2 behaviour working as designed.
- `DefaultProjectDependenciesResolver` (maven-core 3.9.16) never reads
`MavenProject.getArtifacts()`; it collects from `getDependencyArtifacts()` or,
when that is null, from `getDependencies()`. `DependencyGraphProject` already
returns null from `getDependencyArtifacts()`, so the copied resolved set cannot
leak into the graph.
- In `analyze-testDependencyWithNonTestScope`, `junit:junit:3.8.1:compile`
is reachable through `maven-project:2.0.6 →
plexus-container-default:1.0-alpha-9-stable-1` (visible in `dependency:tree
-Dscope=compile`). #294 suppresses the "move to test scope" warning in exactly
that case, and its description already names this IT as the one project whose
expectation changes.
Verified: built #302 as 1.17.3-SNAPSHOT and ran the maven-dependency-plugin
IT against it → same failure as with 1.17.2 ("Can't find table entry under
CompileScopedTestDependencies"). The fix is on the plugin side:
apache/maven-dependency-plugin#1695 drops the leftover `maven-project:2.0.6`
from the IT and bumps to 1.17.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
