slachiewicz opened a new pull request, #251:
URL: https://github.com/apache/maven-reporting-impl/pull/251

   Doxia Sitetools 2.0.0 deprecated `Renderer` as an empty subinterface of 
`SiteRenderer`; this switches the protected `siteRenderer` field and 
`getSiteRenderer()` to `SiteRenderer`.
   
   Source compatibility for reporting plugins is kept: a subclass overriding 
`getSiteRenderer()` with the old `Renderer` return type is a covariant override 
and still compiles (maven-changelog-plugin does this). The change is 
binary-incompatible for a subclass compiled against the old field type that 
reads `siteRenderer` directly, so it may be better placed on the next minor 
than on 4.0.1.
   
   Verified: `mvn verify -Dmaven.compiler.showDeprecation=true` under JDK 17 → 
the `Renderer` warning is gone, 6 ITs passed. The remaining deprecations in 
`AbstractMavenReport` (`ReaderFactory`, `WriterFactory.UTF_8`, 
`SiteTool.getSiteModel` overload, `MessageBuilder.toString`) are out of scope 
here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to