slachiewicz opened a new pull request, #693: URL: https://github.com/apache/maven-doxia-sitetools/pull/693
Under Maven 4, site descriptor inheritance from a parent that is not in the reactor stops working: `DefaultSiteTool` decides "parent is in the repository" by `getBasedir() == null`, which holds on Maven 3, but Maven 4 builds such a parent from the repository copy of its POM, so `basedir` points into the local or project-local repository, the `src/site` lookup finds nothing and the `site_xml` artifact is never resolved. The maven-site-plugin `inheritance-interpolation` IT shows it (the parent's `bannerLeft` is lost; apache/maven-site-plugin#1259 fails on exactly this). The check now also treats a project whose POM file is named `<artifactId>-<version>.pom` as coming from a repository; a checkout's POM never carries that name. No behaviour change on Maven 3. Verified: `SiteToolTest` 16/16; maven-site-plugin `inheritance-interpolation` IT against this snapshot → Passed: 1 with Maven 4.0.0-rc-6 (fails without the change) and with Maven 3.10.0-rc-1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
