gnodet opened a new pull request, #532:
URL: https://github.com/apache/maven-resources-plugin/pull/532

   ## Summary
   
   Implements 
[MRESOURCES-162](https://github.com/apache/maven-resources-plugin/issues/400): 
add a `failOnMissingFilterValue` parameter that causes the build to fail when a 
filter expression in a resource file cannot be resolved, instead of silently 
leaving the placeholder in the output.
   
   ## Usage
   
   ```xml
   <configuration>
     <failOnMissingFilterValue>true</failOnMissingFilterValue>
   </configuration>
   ```
   
   Or via command line:
   ```
   -Dmaven.resources.failOnMissingFilterValue=true
   ```
   
   When enabled, a resource file containing `${missing.property}` (where 
`missing.property` is not defined) will fail with:
   
   ```
   filtering src/main/resources/resource.txt failed with IOException: 
Unresolved filter token: '${missing.property}'
   ```
   
   ## Changes
   
   - `ResourcesMojo`: add `failOnMissingFilterValue` `@Parameter` (default 
`false`, backward compatible), wired into `MavenResourcesExecution`
   - `pom.xml`: bump `mavenFilteringVersion` to `4.0.0-beta-2-SNAPSHOT` 
(requires 
[apache/maven-filtering#408](https://github.com/apache/maven-filtering/pull/408))
   - Two ITs:
     - `MRESOURCES-162-fail`: verifies build fails with the unresolved token in 
the error message
     - `MRESOURCES-162-pass`: verifies default behavior (placeholder passed 
through as-is)
   
   ## Dependency
   
   This PR depends on 
[apache/maven-filtering#408](https://github.com/apache/maven-filtering/pull/408)
 which implements the detection in the filter readers. The 
`mavenFilteringVersion` will be updated to the released version once that PR is 
merged and released.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to