gnodet-bot commented on code in PR #532:
URL:
https://github.com/apache/maven-resources-plugin/pull/532#discussion_r4127357260
##########
src/main/java/org/apache/maven/plugins/resources/ResourcesMojo.java:
##########
@@ -288,6 +288,20 @@ public class ResourcesMojo implements
org.apache.maven.api.plugin.Mojo {
@Parameter(property = "maven.resources.skip", defaultValue = "false")
private boolean skip;
+ /**
+ * When set to {@code true}, the build fails if a filter expression in a
resource file cannot be resolved
+ * (i.e. the placeholder is left unsubstituted in the output). For
example, if a resource contains
+ * {@code ${missing.property}} and no property with that name is defined,
the build will fail instead
+ * of copying the literal text {@code ${missing.property}} to the output.
+ * <p>
+ * Defaults to {@code false} to preserve backward compatibility.
+ * </p>
+ *
+ * @since 4.0.0-beta-2
Review Comment:
⚠️ **Still not addressed from previous review** — `@since 3.4.0` is wrong.
The tag `maven-resources-plugin-3.4.0` is already released. This PR targets
milestone `4.0.0-beta-2`, so this must be:
```suggestion
* @since 4.0.0-beta-2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
