gnodet opened a new pull request, #411:
URL: https://github.com/apache/maven-archiver/pull/411

   ## Summary
   
   Addresses #374.
   
   Null values passed as manifest attribute values are silently accepted and 
converted to empty strings by `sanitizeManifestValue()`. This is intentional 
behaviour (the existing test explicitly exercises it), but it can mask 
programming errors such as an unguarded map lookup returning `null`.
   
   Rather than changing the behaviour, this PR documents the contract clearly 
on all the relevant public methods:
   - `MavenArchiveConfiguration.addManifestEntry()`
   - `MavenArchiveConfiguration.addManifestEntries()`
   - `MavenArchiveConfiguration.getManifestEntries()`
   - `MavenArchiveConfiguration.setManifestEntries()`
   - `MavenArchiver.sanitizeManifestValue()` (private, for maintainers)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to