desruisseaux commented on code in PR #1144: URL: https://github.com/apache/maven-compiler-plugin/pull/1144#discussion_r4179337104
########## src/main/java/org/apache/maven/plugin/compiler/incremental/ExternalAbiResolver.java: ########## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.plugin.compiler.incremental; + +import java.io.IOException; +import java.nio.file.FileSystems; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.attribute.BasicFileAttributes; +import java.util.HashMap; +import java.util.HashSet; +import java.util.LinkedHashMap; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.logging.Level; +import java.util.logging.Logger; + +/** + * Resolves ABI fingerprints for types defined outside the current compilation + * module — in other reactor modules or in external library JARs. + * + * <p>Resolution uses a three-strategy cascade: + * <ol> + * <li><b>Manifest (option 1):</b> If a classpath directory contains an + * {@value AbiManifest#FILENAME} file, fingerprints are read from it. + * This is the fast path for reactor modules compiled with maven-compiler-plugin.</li> Review Comment: Okay, it answers my previous question about who would use the manifest. But if this is about adding the manifest inside the JAR file, this is a whole new topic. It brings the question of our level of commitment to this format, the compatibility with future versions, etc. Can we leave that for a separated pull request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
