desruisseaux commented on PR #1144: URL: https://github.com/apache/maven-compiler-plugin/pull/1144#issuecomment-5984536369
I started the review, but it will be large effort to complete it. Can we break this pull request into smaller ones? My analysis is that this pull request mixes many aspects that could be treated independently: 1. Adding dependency graph for replacing the _one-to-one_ relationship by _one-to-many_ between modified files and compiled files. 2. Adding ABI for replacing "modified files" by "_effectively_ modified files" from the point of view of API consumers. 3. Saving ABI in a manifest file for detecting when a change in a sub-project requires a recompilation of another sub-project. 4. Detecting the type of annotation processors (using non-standard metadata) for deciding which change detection strategy to use. I don't see any reason for addressing those 4 aspects in the same pull request. In my opinion, they can be addressed separately. Can we focus on 1 only for starting? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
