Copilot commented on code in PR #255: URL: https://github.com/apache/maven-remote-resources-plugin/pull/255#discussion_r4218613333
########## src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml: ########## @@ -0,0 +1,42 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<lifecycleMappingMetadata> Review Comment: M2E lifecycle-mapping metadata is commonly authored with the expected XML namespace (and optionally schemaLocation). Omitting the namespace can lead to parsing/validation differences across Eclipse/M2E versions. Consider adding the standard M2E lifecycle-mapping namespace on the root element (and schemaLocation if your project convention uses it) for compatibility. ########## src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml: ########## @@ -0,0 +1,42 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<lifecycleMappingMetadata> + <pluginExecutions> + <pluginExecution> + <pluginExecutionFilter> + <goals> + <goal>aggregate</goal> + <goal>bundle</goal> + <goal>process</goal> + </goals> + </pluginExecutionFilter> Review Comment: This `pluginExecutionFilter` only specifies goals, but M2E lifecycle-mapping filters typically require at least `groupId` and `artifactId` (and commonly `versionRange`) to match a specific plugin execution. Without plugin coordinates, the mapping may not match anything and Eclipse will continue to show unmapped execution warnings. Add the plugin’s `groupId`, `artifactId`, and an appropriate `versionRange` to ensure the ignore action is applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
