Tarun4201 commented on PR #13406: URL: https://github.com/apache/maven/pull/13406#issuecomment-6109026979
All findings from the latest review have been addressed: 1. **Log Level Upgraded (Finding 1)**: Upgraded collision logging in `DefaultProfileInjector` from `DEBUG` to `WARN` so users get immediate visibility if a scoped property overrides an explicit model property. 2. **User Documentation Added (Finding 3)**: Added a "Profile-Scoped Properties" section to `configuring.md` and comprehensive Javadocs in `ProfileInjector` and `DefaultProfileInjector` covering the active-profile rule, reserved namespace, `profile.` prefix exclusion rule, and hyphen recommendation for profile IDs. 3. **PR Description (Finding 2)**: Updated the PR description to accurately describe the single-prefix implementation in `maven-impl`. 4. **CI (Finding 4)**: Ready for maintainer workflow approval to run the full CI suite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
