Tarun4201 commented on PR #13406:
URL: https://github.com/apache/maven/pull/13406#issuecomment-6107969127
Thanks for the follow-up review, @gnodet!
All points have been addressed in the latest rebased commit:
1. **Rebase onto master**:
- Rebased cleanly onto latest `origin/master` (incorporating
`MNG-11642`), resolving the `buildEnvironment()` compilation issue.
2. **Dropped dual prefix**:
- Removed `profiles.<id>.<key>` to keep only `profile.<id>.<key>` as
described in MNG-6885, halving the synthetic entry overhead.
3. **Documented dot-separator profile ID limitation**:
- Added an explanatory comment in `DefaultProfileInjector` documenting
the edge case where dot-containing profile IDs share a prefix relationship with
a property key (last-write-wins applies), and recommending hyphenated/dot-free
IDs. Added test coverage in `ProfileScopePropertiesTest`.
4. **Updated PR description**:
- Updated the PR description to accurately reflect that changes are
isolated to `DefaultProfileInjector` in `impl` and verified by unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
