gnodet-bot commented on code in PR #618: URL: https://github.com/apache/maven-jar-plugin/pull/618#discussion_r4275364816
########## src/site/markdown/examples/manifest-customization.md.vm: ########## @@ -29,18 +29,17 @@ under the License. The Default Manifest -------------------- -The documentation for [Maven Archiver](/shared/maven-archiver/examples/manifest.html) describes the default contents of the manifest. - -Since version 2.1, the Maven JAR Plugin no longer creates the Specification and Implementation details in the manifest by default. -To add them, specify them explicitly in your plugin configuration. -The documentation for [Maven Archiver](/shared/maven-archiver/examples/manifest.html) describes this as well. +The default manifest is built by `ManifestBuilder` based on the `<archive>` configuration. +By default, it includes the `Created-By` attribute (and `Java-Version` when the compiler target is discoverable). Review Comment: ⚠️ **Inaccurate doc:** `Created-By` is no longer added by `ManifestBuilder` — it was removed in the latest commit. In a non-reproducible build (the default), `ToolExecutor` actively *removes* it from the manifest so the `jar` tool can supply its own JDK-stamped value. In a reproducible build, `ToolExecutor` sets it to a JDK-independent string. Suggested correction: ```suggestion By default, it includes the `Java-Version` attribute (when the compiler target is discoverable). ``` Or, if you prefer to document the actual end-result (where `Created-By` always appears in the final JAR via `ToolExecutor`), clarify that it is set by `ToolExecutor`, not `ManifestBuilder`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
