sharanggupta commented on code in PR #13498:
URL: https://github.com/apache/maven/pull/13498#discussion_r4279935496
##########
impl/maven-core/src/test/java/org/apache/maven/plugin/PluginParameterExpressionEvaluatorTest.java:
##########
@@ -94,6 +94,24 @@ void testPluginDescriptorExpressionReference() throws
Exception {
"${plugin} expression does not return plugin descriptor.");
}
+ @Test
+ void testEvaluationWithoutMojoExecution() throws Exception {
Review Comment:
Removed in dcc7b67b04: the fix in master (dd815500df) already adds
`testEvaluationWithoutMojoExecution` and
`testMojoAndPluginExpressionsWithoutMojoExecution`, so this duplicate is gone.
##########
impl/maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java:
##########
@@ -240,7 +247,8 @@ public Object evaluate(String expr, Class<?> type) throws
ExpressionEvaluationEx
try {
int pathSeparator = expression.indexOf('/');
Review Comment:
Agreed, reverted to the line from master in dcc7b67b04.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
