arturobernalg commented on PR #13478: URL: https://github.com/apache/maven/pull/13478#issuecomment-6193425092
@gnodet you are right, thanks for finding it: `maven-executor` reads `MAVEN_ARGS` from the environment of the test JVM, splits it itself, and removes it from the environment of the Maven it forks, so `bin/mvn` never saw the variable and the test did not exercise the script. I rewrote the IT as you suggest: it runs `bin/mvn` (`mvn.cmd` on Windows) directly with `ProcessBuilder` and `MAVEN_ARGS="-Dmaven.repo.local=<path with a space>" -Dprop.plain=plain`, as in the issue, with a project that has no plugin. I ran the same scenario against a distribution with the previous `bin/mvn` (`No goals have been specified for this build`) and with this PR's one (`BUILD SUCCESS`). I did not run the IT through the CI harness. The parser itself is not changed, and the old `eval` is not kept because the quoting cannot work with it. The branch also has a conflict with master in `apache-maven/pom.xml`, which I will resolve next. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
