gnodet commented on PR #13270: URL: https://github.com/apache/maven/pull/13270#issuecomment-6203265187
Thanks for the contribution @sebtiem! The use case this PR addresses — preventing lifecycle phase duplication when running overlapping phases like `mvn compile verify` — is already handled by the concurrent builder (`-b concurrent`) via DAG merge semantics in `BuildPlan`. PR #13532 (now merged) further improved the merge logic to correctly handle overlapping task segments, un-skip phases, and prevent cycles. The approach in this PR (filtering in `DefaultLifecycleExecutionPlanCalculator`) only affects the legacy single-threaded executor and has ordering issues (e.g., `mvn package compile` would silently drop the second `compile`). Given that Maven 4 is moving toward the concurrent builder as the primary execution model, fixing the legacy path is not worth the complexity. Closing in favor of the concurrent builder's existing solution. The relevant JIRA (MNG-5885) can be resolved as "Won't Fix" or linked to the concurrent builder work. _Claude Code on behalf of Guillaume Nodet_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
