fridrich commented on code in PR #1189:
URL:
https://github.com/apache/maven-plugin-tools/pull/1189#discussion_r4294428880
##########
.github/workflows/maven-verify.yml:
##########
@@ -29,3 +29,16 @@ jobs:
maven4-enabled: true # build by Maven 3.x and 4.x
maven4-version: '4.0.0-rc-6' # the same as used in project
+ bootstrap:
+ name: Verify bootstrap profile
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ - uses: actions/setup-java@v4
+ with:
+ distribution: temurin
+ java-version: '17'
+ cache: maven
+ - name: Build with bootstrap profile
+ run: mvn -B -Pbootstrap verify
Review Comment:
Maven 3 resolves build plugins from the reactor: ProjectSorter orders
maven-plugin-plugin after maven-plugin-plugin-bootstrap, and ReactorReader
serves the packaged jar from target/. The suggested mvn install step wouldn't
change anything either, since the bootstrap module skips install on purpose.
The ubuntu-latest runner ships Maven 3.9.x, so this job already runs on Maven 3.
I just run locally mvn -B -Pboostrap verify with a pristine ~/.m2 and all
finished well. That comment that maven 3 cannot resolve reactor plugins from
the local reactor is bogus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
