gnodet opened a new pull request, #13573:
URL: https://github.com/apache/maven/pull/13573
## Summary
- The refactoring in 3e1cb917 stored parent properties only as
`interpolationProperties` (for path interpolation) without updating the model
in `DefaultProfileActivationContext.start()`
- This broke `getModelProperty()` for non-sandboxed project parents, so
`ConditionProfileActivator` could no longer resolve POM-declared properties
like `${pom.declared.prop}` in `<condition>` expressions
- Restores `model.withProperties(interpolationProperties)` so that
`getModelProperty()` returns parent POM properties for project parents
- The dependency/external case remains protected: the sandbox from
`withoutUserPropertiesAndFilesystem()` overrides `getModelProperty()` to return
`null` regardless of the model's content
## Test plan
- [x]
`DefaultModelBuilderTest.testResolvedDependencyParentCacheDoesNotShareActivationWithProjectParent`
passes (was failing on `maven-4.0.x`)
- [x] All 38 tests in `DefaultModelBuilderTest` pass
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]