Sahil-Jaiswal-189 commented on PR #13554:
URL: https://github.com/apache/maven/pull/13554#issuecomment-6221748367
@gnodet I’ve restricted the exports to the six consuming Maven modules as
requested. Two questions came up during verification:
1. Legacy Os access: Moving org.apache.maven.utils.Os from
maven-model-builder into the restricted maven-utils module prevents external
named modules from accessing it. I reproduced an IllegalAccessError with a
previously compiled client. Classpath callers and Maven’s own consumers remain
unaffected. Is this restriction intentional, or should we preserve that legacy
module-path access?
2. Pre-existing interpolation recursion: The following call produces
StackOverflowError rather than an InterpolatorException:
```
DefaultInterpolator.substVars(
"${a}", "outer", null,
Map.of("a", "${a}"), null, null, false);
```
I reproduced this against both the base implementation and this branch,
so the extraction didn’t introduce it. Would you prefer a separate
issue/follow-up fix, or should we address it in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
