gnodet commented on PR #13554: URL: https://github.com/apache/maven/pull/13554#issuecomment-6270555723
Thanks for addressing the feedback. Two points: **1. `Os` visibility on the module path** I'm not sure this is actually a problem in practice. `maven-model-builder` lives in `compat/` and is loaded from the *classpath*, not as a named module. Classpath code runs in the unnamed module, which can access any exported package without restriction — JPMS qualified-export restrictions only apply between named modules. Could you clarify what kind of caller triggered the `IllegalAccessError` you reproduced? If it was a pre-compiled client running with `maven-model-builder` as an explicit `--module-path` entry (rather than classpath), that's already an unsupported configuration. The restriction is intentional. **2. `StackOverflowError` on recursive interpolation** Please open a separate issue targeting `master` for this — it's a pre-existing bug, unrelated to this extraction. No need to fix it in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
