gnodet-bot commented on code in PR #1237:
URL:
https://github.com/apache/maven-plugin-tools/pull/1237#discussion_r4301796573
##########
maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/datamodel/MojoAnnotationContent.java:
##########
@@ -172,6 +176,26 @@ public void requiresOnline(boolean requiresOnline) {
this.requiresOnline = requiresOnline;
}
+ public void onlineRequired(boolean requiresOnline) {
+ this.requiresOnline = requiresOnline;
+ }
+
+ public boolean isDependencyCollection() {
+ return dependencyCollection;
+ }
+
+ public void dependencyCollection(boolean dependencyCollection) {
+ this.dependencyCollection = dependencyCollection;
+ }
+
+ public String getDependencyResolutionPathScopes() {
+ return dependencyResolutionPathScopes;
+ }
+
+ public void dependencyResolutionPathScopes(String
dependencyResolutionPathScopes) {
+ this.dependencyResolutionPathScopes = dependencyResolutionPathScopes;
+ }
Review Comment:
⚠️ **Missing `toString()` update:** The new fields `dependencyCollection`
and `dependencyResolutionPathScopes` are not included in the existing
`toString()` method. Debug logging that prints a `MojoAnnotationContent`
instance will silently omit these fields, which can make troubleshooting
annotation descriptor issues harder. Please add both fields to `toString()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
