gnodet-bot commented on code in PR #13605:
URL: https://github.com/apache/maven/pull/13605#discussion_r4306229303


##########
impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java:
##########
@@ -966,14 +966,14 @@ public List<String> getModules() {
     }
 
     public PluginManagement getPluginManagement() {

Review Comment:
   💡 The contract change (never returns `null`) deserves Javadoc so callers 
don't need to guess. Example:
   
   ```suggestion
       /**
        * Returns the plugin management configuration for this project.
        * Never returns {@code null} — yields an empty {@link PluginManagement} 
when
        * no plugin management is defined in the effective model.
        *
        * @return plugin management, never {@code null}
        */
       public PluginManagement getPluginManagement() {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to