Shreekar-cloud commented on PR #13605: URL: https://github.com/apache/maven/pull/13605#issuecomment-6261354273
Tested locally on Windows with JDK 25 (Temurin) at PR head e0020d0f (base 889ccadf): MavenProjectTest: 14 tests, 0 failures. Reverting only MavenProject.java to the base version makes the new pluginManagementShouldReturnNotNull fail with expected: not <null> (MavenProjectTest.java:265), so the test does cover the change. org.apache.maven.lifecycle.*Test and org.apache.maven.lifecycle.internal.*Test (the packages containing the callers DefaultMojoExecutionConfigurator, MojoDescriptorCreator and LifecyclePluginResolver): 39 tests, 0 failures. mvn test left the working tree unmodified, so no formatter changes were needed. One question, not a request: when the model has no plugin management, the method now returns a fresh PluginManagement that isn’t attached to the model, so a caller that adds plugins to it would lose them silently (before, it got an NPE). Is that the intended contract? A short Javadoc note might help. Separately, the != null checks in DefaultMojoExecutionConfigurator and MojoDescriptorCreator look redundant now, but that is optional cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
