slawekjaranowski commented on PR #13608: URL: https://github.com/apache/maven/pull/13608#issuecomment-6248324154
> The trigger change is sound and the shared workflow at `@v5` supports both `push` and `pull_request_target` — the `pr` job conditionally handles each, and the `pr-number` action resolves the merged PR from the merge commit SHA. Downstream jobs guard on `merged == 'true'`, so a direct push to master without a corresponding PR produces a safe no-op. > > One thing worth double-checking: `maven-4.0.x` has the same `pull_request_target: closed` workflow and will also be affected by the November 2026 ASF restriction. Since the PR description says this is "Part of [apache/maven-gh-actions-shared#334](https://github.com/apache/maven-gh-actions-shared/issues/334)", is there a follow-up planned for the `maven-4.0.x` branch, or does that branch not need the same treatment (e.g. because it's maintained on a different cadence)? > > _This review was generated by an AI agent, Hermès on behalf of @gnodet._ maintenance branches have a separate PRs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
