gnodet-bot commented on code in PR #561:
URL:
https://github.com/apache/maven-resources-plugin/pull/561#discussion_r4433335762
##########
src/site/site.xml:
##########
@@ -32,18 +32,14 @@ under the License.
<item name="Download" href="download.html"/>
</menu>
<menu name="Examples">
- <item name="Specifying a character encoding scheme"
- href="/examples/encoding.html"/>
+ <item name="Filtering resources (guide)"
+
href="https://maven.apache.org/guides/mini/guide-filtering-resources.html"/>
Review Comment:
💡 **Suggestion** (not a blocker): the label `Filtering resources (guide)`
replaces three separate items (`Specifying a character encoding scheme`,
`Filtering`, `Escape Filtering`). Users searching the nav for *encoding* will
no longer find it under that term. Consider `Filtering & encoding (guide)` to
preserve discoverability.
##########
src/site/markdown/index.md:
##########
@@ -57,13 +57,10 @@ If you feel like the plugin is missing a feature or has a
defect, you can fill a
## Examples
-The following examples show how to use the Resources Plugin in more advanced
use cases:
+The [guide to filtering
resources](https://maven.apache.org/guides/mini/guide-filtering-resources.html)
covers variables, filter files, escaping and encoding. The following examples
show how to use the Resources Plugin in more advanced use cases:
Review Comment:
🔗 **Broken link** — this URL currently returns HTTP 404. It will only become
valid after [maven-site#1758](https://github.com/apache/maven-site/pull/1758)
is merged and published.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
