slachiewicz opened a new pull request, #359:
URL: https://github.com/apache/maven-fluido-skin/pull/359

   Replaces prettify, which Google archived in 2020, with highlight.js 11.12.0. 
The markup stays as it was: `site.vm` still marks code blocks with 
`prettyprint` and `linenums`, so custom CSS and the ITs are unaffected; 
`fluido.js` now highlights those blocks.
   
   - Grammars: XML, Java, Bash, shell, JSON, properties, Groovy, JavaScript and 
plain text. A block without a language, or with one highlight.js lacks, is 
detected among them. That matters for Markdown's ```` ```unknown ````, used by 
18 of the 38 fenced blocks in maven-compiler-plugin's site.
   - `sourceLineNumbersEnabled` keeps working through 
highlightjs-line-numbers.js 2.9.1.
   - Colours: the GitHub theme, and GitHub Dark in the opt-in dark theme.
   - `js/highlight-11.12.0.min.js` (43 kB; prettify was 13.6 kB) is composed 
from unmodified release files, listed in its header. If it does not load, code 
stays plain and readable.
   
   Closes #277. Builds on michael-o's draft in #65, which predates the dark 
theme and dropped line numbers. Part of #355.
   
   Verified: `mvn -P run-its verify` → 40 + 1 passed; in Chromium on the 
verbatim and sidebar ITs and on a maven-compiler-plugin render, every code 
block is highlighted, line numbers are present where enabled, and no script 
errors occur.
   
   ---
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](https://www.apache.org/licenses/LICENSE-2.0)
   check one of the following:
   
   - [ ] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
   - [x] I hereby declare that I have filed an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to