slachiewicz opened a new pull request, #365: URL: https://github.com/apache/maven-fluido-skin/pull/365
The highlight.js GitHub theme assumes a white background. On the skin's `#f5f5f5` code blocks, tag names (`#22863a`, 4.24:1), keywords (`#d73a49`, 4.2:1), built-ins (`#e36209`, 3.2:1) and comments (`#6a737d`, 4.42:1) miss the WCAG 4.5:1 minimum. This is new since 2.1.0, which had no token colours. They are darkened to 4.5–5.2:1 in `maven-theme.css`, and the theme stylesheet now comes first in the bundle so those rules win; `dark-theme.css` loads separately afterwards, so the dark colours are unchanged. Verified: axe on maven-site `introduction-to-the-pom.html` → colour-contrast nodes 330 → 126 (2.1.0: 134; the rest are menu link colours), none on highlight.js tokens; computed colours on the mskins-255 output: light uses the new values, dark keeps `#7ee787`/`#8b949e`/`#ff7b72`; ITs 41/41. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
