slachiewicz opened a new pull request, #732: URL: https://github.com/apache/maven-doxia-sitetools/pull/732
Carries https://github.com/apache/maven-doxia-sitetools/pull/623 by @michael-o: his commit as authored, then one commit on top that settles the review points. - One system property, `maven.doxia.sitetools.default.locale`, without the `user` infix. It takes the form of the site plugin's `locales` parameter (`en`, `en_US`, `en_US_POSIX`, the reverse of `Locale#toString()`), and a value containing `-` is read as a language tag (`en-US`). The parser is the static `SiteTool.toLocale(String)` and never throws, since a failure there would fail the interface's initialization. - Parent site descriptors: parents attach `site.xml` with the plain `site` classifier, but the last fallback asked for `site_<default locale>`. With the property set to `en`, a child lost every inherited descriptor. The fallback now asks for `site`. - The property is read once, when `SiteTool` is loaded, so under mvnd a later build keeps the first value; the Javadoc says so. Verified: `SiteToolTest#siteDescriptorFromRepositoryFallsBackToPlainClassifier` with `-DargLine=-Dmaven.doxia.sitetools.default.locale=en` fails with a null descriptor without the fallback change and passes with it. Merge with "Rebase and merge" so michael-o's commit keeps its authorship. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
