slachiewicz opened a new pull request, #1435: URL: https://github.com/apache/maven-javadoc-plugin/pull/1435
Fixes #1434. `--add-stylesheet` is now added when the javadoc tool is 10 or later, as detected (or set through `javadocVersion`), instead of when the JVM running Maven is. The new `testAddStylesheetsOnJavadoc9` sets `javadocVersion` to 9 on a newer JVM and fails without the fix. `isJavaDocVersionAtLeast` and its two `addArgIfNotEmpty` overloads have no callers left after this; they are left for #1429 to remove, so the two PRs do not conflict. Verified: `mvn -B verify` → 82 of 83 unit tests pass; the other, `testJavadocResourcesWithExcludes`, fails only on a rerun over stale fixture output and passes after cleaning it, the same as on master --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [x] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
