slachiewicz opened a new pull request, #1407: URL: https://github.com/apache/maven-assembly-plugin/pull/1407
Moves 26 file and file-set ITs into unit tests that run real assembly descriptors through `DefaultAssemblyArchiver`, the real archivers and the files/file-sets phases in a temporary directory (`AssemblyRunner`): output directories and interpolated includes, default excludes, symbolic links, file modes, base directories, precedence, platform-specific path warnings, filtering with build filters, system properties and Latin-1 properties, zstd formats and the configured file aggregator. Each new test fails when the production line it guards is broken. The three default-excludes ITs asserted `.svn` was absent without ever creating one (#1406); their unit tests create it. The `configured-handler` IT's content check never ran: the aggregated file today holds only its header, so the test asserts what holds now. The ITs that need project building stay. Part of apache/maven#13822. Verified: unit tests 273 → 302 run (304 declared, 2 Windows-only skipped); ITs 154 → 128; a 10-IT sample passes with `-P run-its` --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [x] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
