gnodet commented on PR #13636: URL: https://github.com/apache/maven/pull/13636#issuecomment-6663317648
<!-- forgebot --> Addressed the Plexus isolation review point. Here's what landed: **New types (all package-private in `org.apache.maven.plugin.internal`):** - `MojoExpressionEvaluator` — thin interface: `evaluate(String, Class<?>)` + `alignToBaseDirectory(File)` - `MojoExpressionEvaluationException` — unchecked wrapper, no Plexus in its signature - `PlexusMojoExpressionEvaluatorAdapter` — adapts `TypeAwareExpressionEvaluator` to the new interface **Result:** `V4MojoConfigurator` now has zero Plexus API imports. The Plexus coupling is fully confined to `DefaultMavenPluginManager` (construction site) and `PlexusMojoExpressionEvaluatorAdapter` (the adapter itself). **Tests:** `V4MojoConfiguratorTest` now mocks `MojoExpressionEvaluator` directly — no Plexus imports. A test-scoped `V4MojoConfiguratorTestHelper` (same `internal` package) lets the two integration tests in `org.apache.maven.plugin` reach the adapter without breaking the package-private boundary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
