gnodet commented on PR #13636: URL: https://github.com/apache/maven/pull/13636#issuecomment-6664859693
<!-- forgebot --> Addressed the compile error and unchecked cast (pushed as `0f23b90547`): **MojoExtension compile error** — added a `public` constructor on `V4MojoConfigurator` that takes `TypeAwareExpressionEvaluator` directly, so `maven-testing` can use it without crossing into the package-private adapter. `MojoExtension` now casts `WrapEvaluator` (which already implements `TypeAwareExpressionEvaluator`) at the call site. **DefaultMavenPluginManager unchecked cast** — replaced the raw `(TypeAwareExpressionEvaluator)` cast with an `instanceof` pattern-match that throws `PluginConfigurationException` early with a clear diagnostic. 78/78 tests green (maven-core + maven-testing). --- **On the `org.apache.maven.configuration` deletion:** confirmed this package is listed in `extension.xml` `<exportedPackage>` on master. That's a judgement call for the PR author and maintainers — the options are: 1. Add `@Deprecated` to all 11 classes + keep the package this release, remove in a future version. 2. Accept the break as intentional (this is Maven 4 alpha/RC territory where API stability is loosened). This is not a change we introduced — it was part of the original PR. Flagging it for the author to decide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
