gnodet commented on issue #2569: URL: https://github.com/apache/maven/issues/2569#issuecomment-6671192654
Hi @codewithsinchana, the fix is already applied — no separate contribution needed! PR #12377 has just been rebased onto master and now includes: 1. **Removal of `getSource()`/`setSource()` from the 4.2.0+ API model** — POM vs settings profiles are now distinguished via `InputSource.getModelId()` (non-empty = POM, empty/null = settings) 2. **Compat-layer fix** — `SettingsUtils.convertFromSettingsProfile()` now explicitly calls `result.setSource(Profile.SOURCE_SETTINGS)`, preserving correct `activeByDefault` behaviour for settings profiles in the deprecated compat `DefaultProfileSelector` 3. **Updated `ConditionProfileActivator` and `PropertyProfileActivator`** — these also used `Profile.SOURCE_POM.equals(profile.getSource())` for cascaded property lookups and are now using the `InputSource.getModelId()`-based check consistently 4. **Merged test suite** — cascading activation tests and new `isFromPom()`/`activeByDefault` regression tests (the scenario from your analysis) are both included Your PR #13854 helped surface the compat-layer regression clearly, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
