gnodet-bot commented on code in PR #13658:
URL: https://github.com/apache/maven/pull/13658#discussion_r4531926996


##########
impl/maven-core/src/main/java/org/apache/maven/lifecycle/internal/concurrent/BuildPlanExecutor.java:
##########
@@ -192,6 +192,14 @@ public BuildPlanExecutor(
         this.lifecycles = lifecycles;
     }
 
+    private static boolean requiresDependencyOrdering(MojoDescriptor 
descriptor) {

Review Comment:
   ⚠️ **Dead code — merge conflict resolution dropped the call site.**
   
   Commit `432ab5f6` added this method AND correctly updated the planning loop 
at the time (replacing the raw null-check with 
`requiresDependencyOrdering(mojoDescriptor)`). But when merging `origin/master` 
(`493192e2`), the conflict in this file was resolved by accepting master's code 
— the call site was dropped. In HEAD, this method is **never called**.
   
   The active check at line 727 (from master) is:
   ```java
   if (descriptor.getDependencyCollectionRequired() != null
           || descriptor.getDependencyResolutionRequired() != null) {
   ```
   
   This check will never be true for V4 mojos using `@Resolution` fields 
without an explicit `dependencyResolutionPathScopes` on `@Mojo` — because 
`inferDependencyResolution()` was also removed in this commit. Those mojos will 
silently get no upstream dependency ordering in concurrent builds.
   
   **Fix** — update line 727 (not in diff; apply separately):
   ```java
   if (requiresDependencyOrdering(descriptor)) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to