gnodet commented on code in PR #13832:
URL: https://github.com/apache/maven/pull/13832#discussion_r4548348276
##########
compat/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -1646,8 +1636,9 @@ static void performProfileActivation(final CommandLine
commandLine, final Profil
}
}
- private ExecutionListener determineExecutionListener() {
- ExecutionListener executionListener = new
ExecutionEventLogger(messageBuilderFactory);
+ private ExecutionListener determineExecutionListener(CliRequest
cliRequest) {
+ ExecutionListener executionListener = new ExecutionEventLogger(
+ messageBuilderFactory,
org.slf4j.LoggerFactory.getLogger(ExecutionEventLogger.class), -1);
Review Comment:
Already addressed — the compat MavenCli now uses
LoggerManager.get().hasReached(level) which tracks severity across all logger
paths (SLF4J, JUL, Maven API).
##########
compat/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -1646,8 +1636,9 @@ static void performProfileActivation(final CommandLine
commandLine, final Profil
}
}
- private ExecutionListener determineExecutionListener() {
- ExecutionListener executionListener = new
ExecutionEventLogger(messageBuilderFactory);
+ private ExecutionListener determineExecutionListener(CliRequest
cliRequest) {
+ ExecutionListener executionListener = new ExecutionEventLogger(
+ messageBuilderFactory,
org.slf4j.LoggerFactory.getLogger(ExecutionEventLogger.class), -1);
Review Comment:
Already addressed — the compat MavenCli now uses
LoggerManager.get().hasReached(level) which tracks severity across all logger
paths (SLF4J, JUL, Maven API).
##########
impl/maven-logging-slf4j/src/main/java/org/apache/maven/logging/slf4j/MavenLoggerFactory.java:
##########
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.logging.slf4j;
+
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+
+import org.apache.maven.api.logging.LoggerManager;
+import org.apache.maven.logging.impl.DefaultLoggerManager;
+import org.slf4j.ILoggerFactory;
+import org.slf4j.Logger;
+
+/**
+ * LogFactory for Maven which creates SLF4J loggers that delegate level checks
+ * and severity recording to the shared {@link DefaultLoggerManager}.
+ */
+public class MavenLoggerFactory implements ILoggerFactory {
+ static volatile MavenLoggerFactory instance;
+
+ private static final StackWalker STACK_WALKER =
StackWalker.getInstance(StackWalker.Option.RETAIN_CLASS_REFERENCE);
+
+ final DefaultLoggerManager logManager;
+ final ConcurrentMap<String, Logger> loggerMap = new ConcurrentHashMap<>();
+
+ public MavenLoggerFactory() {
+ instance = this;
+ LoggerManager mgr = LoggerManager.get();
+ if (mgr instanceof DefaultLoggerManager dlm) {
+ logManager = dlm;
+ } else {
+ logManager = new DefaultLoggerManager();
+ LoggerManager.set(logManager);
+ }
+ logManager.addReconfigurationListener(this::updateExistingLoggers);
+ }
+
+ @Override
+ public Logger getLogger(String name) {
+ // Fast path: if a logger is already cached by name alone (non-plugin
case),
+ // return it without performing an expensive stack walk.
+ Logger cached = loggerMap.get(name);
+ if (cached != null) {
+ return cached;
+ }
+
Review Comment:
Already addressed — getLogger() always resolves pluginId first and uses
name+pluginId as cache key, so different plugins get distinct loggers. Comment
at lines 57-60 explains the design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]