gnodet-bot commented on PR #14024:
URL: https://github.com/apache/maven/pull/14024#issuecomment-6916824597

   **`MavenCliLoggingTest.java` deleted — 450 lines of concurrency coverage 
lost**
   
   This test class verified that the `-l` branch awaited terminal installation 
before redirecting `System.out`, preventing the race documented in #12188. It 
also validated that `color=always` bypassed the wait (so the logger cached the 
right stream).
   
   Both behaviors are gone (`awaitTerminalInitialization()` no longer exists), 
and so are the tests. The PR description argues the new design eliminates the 
race by removing `AnsiConsole.systemInstall()` — but no replacement test 
validates that claim.
   
   Without a test, this regression risk is invisible: if a future change 
re-introduces `System.out` wrapping in the terminal consumer (e.g. a new Jansi 
integration), the `-l` stream redirect race (#12188) can silently resurface. 
Consider adding a narrower test that verifies the `-l` stream redirect is not 
overwritten when `systemInstall()` runs concurrently.
   
   _This comment was generated by an AI agent, Hermès on behalf of @gnodet._
   <!-- reviewer: gnodet-bot -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to