gnodet-bot commented on code in PR #14028:
URL: https://github.com/apache/maven/pull/14028#discussion_r4588123575


##########
impl/maven-core/src/main/java/org/apache/maven/configuration/internal/EnhancedCompositeBeanHelper.java:
##########
@@ -301,9 +304,19 @@ private Object convertProperty(
      * Set field value with cached accessibility.
      */
     private void setFieldValue(Object bean, Field field, Object value) throws 
IllegalAccessException {
-        if (!field.canAccess(bean)) {
+        Boolean isAccessible = ACCESSIBLE_FIELD_CACHE.get(field);
+        if (isAccessible == null) {
+            isAccessible = field.canAccess(bean);
+            if (!isAccessible) {
+                field.setAccessible(true);
+                isAccessible = true;
+            }
+            ACCESSIBLE_FIELD_CACHE.put(field, isAccessible);
+        } else if (!isAccessible) {
             field.setAccessible(true);
+            ACCESSIBLE_FIELD_CACHE.put(field, true);
         }

Review Comment:
   ⚠️ **Dead code — this branch is unreachable.**
   
   In the `null` branch above, when `canAccess(bean)` returns `false`, the code 
immediately sets `isAccessible = true` before calling `put(field, 
isAccessible)`. The cache therefore **always stores `true`** and can never 
contain `false`. This `else if (!isAccessible)` block will never execute.
   
   Simplest fix — remove the dead branch:
   
   ```suggestion
           if (isAccessible == null) {
               isAccessible = field.canAccess(bean);
               if (!isAccessible) {
                   field.setAccessible(true);
                   isAccessible = true;
               }
               ACCESSIBLE_FIELD_CACHE.put(field, isAccessible);
           }
   ```
   
   Or replace `ConcurrentMap<Field, Boolean>` with `Set<Field>` (via 
`ConcurrentHashMap.newKeySet()`) since only the `true`/"has been made 
accessible" case is ever stored.
   
   Note: the same dead code is in the original PR #2526 on `master`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to