slachiewicz opened a new issue, #501:
URL: https://github.com/apache/maven-install-plugin/issues/501

   Follow-up to #497, which is closed. Both lines still have 25 IT directories 
(23 shared). This issue covers the next tranche; `maven-install-plugin-4.x` 
stays Maven 4 only.
   
   ## Triage of the remaining ITs
   
   **Move to unit tests — first slice**
   - `install-file-minstall-121` and its five variants (`-bundle`, 
`-java-source`, `-maven-archetype`, `-targz`, `-war`) — each only asserts that 
`file`, `pomFile` and `packaging` produce the expected installed coordinates 
and file extension. One parameterized JUnit 5 test can replace all six.
   - `install-file-missing-file` — failure-only IT with no verify script; 
already covered by `fileDoesNotExists` on both branches.
   - `local-repo-override` — already covered by the converted 
`installFileIntoOverriddenLocalRepository*` tests.
   
   **Move to unit tests — second slice (after the first lands)**
   - `jar-sources-javadoc` (jar + sources + javadoc installation), 
`install-file-generated-pom` (coordinates inherited from the embedded POM), 
`attach-release-jar`, `release-jar`, `release-pom`, `snapshot-jar`, 
`snapshot-pom` — check the existing unit tests for exact coverage before adding 
new ones; most are plain file-existence checks.
   
   **Keep as ITs**
   - Reactor / deferred install: `install-at-end-default`, 
`install-at-end-fail`, `install-at-end-pass`, `install-at-end-phase-and-skip`, 
`per-project-config`, `pom-packaged-project-installs-pom`.
   - Parallel: `parallel-reactor-install`, `install-file-parallel` (`-T2`).
   - Forked / build-shape: `non-default-pom` (`-f`), 
`install-file-embedded-pom` (`package install:install-file`), 
`setup-mock-phase-maven-plugin` (support project).
   
   **Fix / cleanup**
   - Several surviving `verify.groovy` scripts still use `throw` + `return 
true` instead of `assert`; handle separately from the moves.
   - `install-file-missing-file` has no verify script at all.
   
   ## Checklist
   
   - [ ] First slice: six `minstall-121` ITs → one parameterized unit test on 
each branch; delete the two duplicate ITs.
   - [ ] Mutation-check the new parameterized assertions.
   - [ ] Second slice: remaining simple file-existence ITs.
   - [ ] Convert surviving verify scripts to `assert` form.
   - [ ] Re-measure CI and close with the last PR.
   
   All test code must be JUnit 5. No Plexus Utils in new code. No merges by me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to