slachiewicz opened a new pull request, #503:
URL: https://github.com/apache/maven-install-plugin/pull/503

   Part of #501. Companion to #502 on the 3.x line. This branch remains Maven 4 
only.
   
   Replaces the six `install-file-minstall-121*` integration tests with one 
parameterized JUnit 5 test, `installFileUsesPackagingForArtifactExtension`. 
Each of the six cases supplies `file`, `pomFile`, `packaging` and the expected 
extension and asserts the exact installed artifact and POM paths, the 
coordinates handed to the installer, the used POM's model, the fixture files' 
continued existence, the local-repository path and absence of checksum files. 
The fixtures live under `src/test/resources/unit/artifact-extension/` and are 
named for what they test, not by JIRA key.
   
   Also removes two exact duplicates: `install-file-missing-file` (covered by 
`fileDoesNotExists`) and `local-repo-override` (covered by 
`installFileIntoOverriddenLocalRepositoryNoChecksums`).
   
   Unit tests went from 45 to 51; all pass. Added `junit-jupiter-params` in 
test scope. No production code changed, no Plexus Utils added.
   
   Verification (JDK 21, Maven 4.0.0-rc-7): `mvn -o -B clean test 
spotless:check` → 51/51 green, 0 Checkstyle violations.
   
   Known harness caveats, documented in the test: `maven-metadata-local.xml` is 
written by the real `ArtifactInstaller`, which the Maven 4 `@MojoTest` harness 
mocks, so its path is implied by the asserted coordinates; and `SessionMock` 
does not map `java-source` to the `sources` classifier, so that case supplies 
it explicitly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to