elharo commented on code in PR #653:
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/653#discussion_r4658107264


##########
src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java:
##########
@@ -581,37 +579,16 @@ private void addResourceFilesToProcess(
         }
     }
 
-    /**
-     * Builds a {@code SuppressionFilter} module configured with the given 
suppressions file, the same way
-     * Checkstyle builds one when it is declared as a module in the checker 
configuration.
-     * <p>
-     * This matters for the cache file (MCHECKSTYLE-372): Checkstyle 
invalidates its cache for an external
-     * resource only when the module holding it implements {@code 
ExternalResourceHolder}, which
-     * {@code SuppressionFilter} does but a pre-parsed {@code FilterSet} does 
not. Loading the suppressions
-     * ourselves and adding the result as a plain {@code FilterSet} - as this 
method used to - left Checkstyle
-     * with no way to notice the suppressions file had changed, so edits to it 
were silently ignored as long
-     * as the cache file was still considered up to date for everything else.
-     *
-     * @param suppressionsFilePath absolute path to the suppressions file, or 
{@code null} if none configured
-     * @return the configured filter, or {@code null} if {@code 
suppressionsFilePath} is {@code null}
-     * @throws CheckstyleExecutorException if the suppressions file cannot be 
loaded
-     */
-    private Filter createSuppressionFilter(final String suppressionsFilePath) 
throws CheckstyleExecutorException {
+    private FilterSet getSuppressionsFilterSet(final String 
suppressionsFilePath) throws CheckstyleExecutorException {

Review Comment:
   seems like an unrelated change got overwritten in the merge; fix this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to