[ 
http://jira.codehaus.org/browse/MSHARED-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160248#action_160248
 ] 

Paul Jackson commented on MSHARED-78:
-------------------------------------

IMO, Filtering should not automatically add escape characters - it takes 
control away from a user.  Better to never add escape characters and leave it 
to the user to add them as necessary.

> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
>                 Key: MSHARED-78
>                 URL: http://jira.codehaus.org/browse/MSHARED-78
>             Project: Maven Shared Components
>          Issue Type: Improvement
>          Components: maven-filtering
>    Affects Versions: maven-filtering-1.0-beta-2
>            Reporter: Marvin Froeder
>             Fix For: maven-filtering-1.0-beta-4
>
>         Attachments: FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing  colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that.  If you try to open D\:\\temp on 
> explorer, will not work.
> Even java.io.File is not able to handle that too.  The attached test proves 
> it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of 
> org.apache.maven.shared.filtering.FilteringUtils make the test work.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to