[ 
http://jira.codehaus.org/browse/MNG-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160483#action_160483
 ] 

Benjamin Bentmann commented on MNG-3974:
----------------------------------------

The code in {{DefaultWagonManager}} from trunk appears to support the extended 
mirror syntax. For instance, the IT for MNG-3461 checking "external:*" passes 
with Maven 3.x.

However, according to Brian's proposal and the comments in {{getMirror()}}, the 
first match should win. But the loop is not quit upon a match but continues, 
potentially choosing a later match. Could that be the cause for Brian's issue?

While we talk about ordering of mirrors, for a {{settings.xml}}
{code:xml}
<mirrors>
  <mirror>
    <id>test-a</id>
    <url>...</url>
    <mirrorOf>foo</mirrorOf>
  </mirror>
  <mirror>
    <id>test-b</id>
    <url>...</url>
    <mirrorOf>foo</mirrorOf>
  </mirror>
</mirrors>
{code}
the mirror "test-b" will be chosen, i.e. the last definition, due later mirrors 
with equal mirrorOf overriding the former ones. Doesn't feel very consistent 
with the strategy of first match wins.

> New mirror syntax is not supported in 3.0
> -----------------------------------------
>
>                 Key: MNG-3974
>                 URL: http://jira.codehaus.org/browse/MNG-3974
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Artifacts and Repositories
>    Affects Versions: 3.0-alpha-1
>            Reporter: Brian Fox
>            Assignee: Brian Fox
>             Fix For: 3.0-alpha-2
>
>
> The new mirror syntax introduced in 2.0.9 / MNG-3461 is not implemented in 
> 3.0 yet.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to