[ 
http://jira.codehaus.org/browse/MNG-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=199101#action_199101
 ] 

Benjamin Bentmann edited comment on MNG-3902 at 11/23/09 11:46 AM:
-------------------------------------------------------------------

Done in [r883430|http://svn.apache.org/viewvc?view=revision&revision=883430].

To avoid code complexity due to multiple code paths, the session will still use 
a stub project to carry around the information (repos, properties) from 
external profiles during POM-less execution. However, the project builder only 
supports this implementation detail via general purpose method that allows to 
build projects from some ModelSource.

      was (Author: bentmann):
    Done in [r|http://svn.apache.org/viewvc?view=revision&revision=883430].

To avoid code complexity due to multiple code paths, the session will still use 
a stub project to carry around the information (repos, properties) from 
external profiles during POM-less execution. However, the project builder only 
supports this implementation detail via general purpose method that allows to 
build projects from some ModelSource.
  
> Remove visibility MavenProjectBuilder#buildStandaloneSuperProject
> -----------------------------------------------------------------
>
>                 Key: MNG-3902
>                 URL: http://jira.codehaus.org/browse/MNG-3902
>             Project: Maven 2
>          Issue Type: Task
>    Affects Versions: 3.0-alpha-1
>            Reporter: Jason van Zyl
>            Assignee: Benjamin Bentmann
>             Fix For: 3.0-alpha-6
>
>
> This method does not need to be exposed beyond the project building code. 
> It's used currently in two places:
> 1) To provide a default model when you execute a goal that has no POM. Here 
> we have to deal gracefully without its presence because there may actually be 
> times we need to know when there is no POM available. The null pattern here 
> cause the exposure of this method and propagated lots of internal logic that 
> can no longer differentiate when a project is present or not.
> 2) To get the default remote repositories. These should be placed somewhere 
> else as simple values so that we don't have to invoke such a big piece of 
> machinery just to extract those values.
> Need to find all the plugins that may rely on this method, as almost every 
> method in the project builder is being misused in one plugin or another.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to