[ 
https://jira.codehaus.org/browse/MRELEASE-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=300227#comment-300227
 ] 

Robert Scholte commented on MRELEASE-726:
-----------------------------------------

Is this still happening with version 2.3.1?
A quick scan over the code tells me that a {{pom.xml}} and optional 
{{release-pom.xml}} should be committed at once when {{commitByProject}} is 
activated.
I can't see during which release-phase this commit is happening, so could you 
add more (debug)-logging?
                
> mvn release:prepare-with-pom not honouring the commitByProject parameter.
> -------------------------------------------------------------------------
>
>                 Key: MRELEASE-726
>                 URL: https://jira.codehaus.org/browse/MRELEASE-726
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: Git, prepare-with-pom
>    Affects Versions: 2.2.2
>         Environment: Linux 64bit (Ubuntu).
>            Reporter: Dave Fennell
>            Priority: Blocker
>
> Using this in my pom file:
> {code:xml}
>                       <plugin>
>                               <groupId>org.apache.maven.plugins</groupId>
>                               <artifactId>maven-release-plugin</artifactId>
>                               <version>2.2.2</version>
>                               <configuration>
>                                       <goals>deploy</goals>
>                                       <pushChanges>false</pushChanges>
>                                       <localCheckout>true</localCheckout>
>                                       <commitByProject>true</commitByProject>
>                               </configuration>
>                       </plugin>
> {code}
> Running this command:
> {{mvn release:prepare}}
> Correctly goes into each directory to make changes, e.g. 
> {noformat}
> [INFO] Checking in modified POMs...
> [INFO] Executing: /bin/sh -c cd /usr/local/src/whitelabel && git add -- 
> pom.xml
> [INFO] Working directory: /usr/local/src/whitelabel
> [INFO] Executing: /bin/sh -c cd /usr/local/src/whitelabel && git status
> [INFO] Working directory: /usr/local/src/whitelabel
> [INFO] Executing: /bin/sh -c cd /usr/local/src/whitelabel && git commit 
> --verbose -F /tmp/maven-scm-561169862.commit pom.xml
> [INFO] Working directory: /usr/local/src/whitelabel
> [INFO] Executing: /bin/sh -c cd /usr/local/src/whitelabel/foundation && git 
> add -- pom.xml
> [INFO] Working directory: /usr/local/src/whitelabel/foundation
> [INFO] Executing: /bin/sh -c cd /usr/local/src/whitelabel/foundation && git 
> status
> [INFO] Working directory: /usr/local/src/whitelabel/foundation
> [INFO] Executing: /bin/sh -c cd /usr/local/src/whitelabel/foundation && git 
> commit --verbose -F /tmp/maven-scm-2018482909.commit pom.xml
> {noformat}
> etc ...
> However running this command:
> {{mvn release:prepare-with-pom}}
> So that I can generate a release-pom.xml file errors because it attempts to 
> do all the checkins on one line:
> {noformat}
> [INFO] Executing: /bin/sh -c cd /usr/local/src/whitelabel && git add -- 
> release-pom.xml foundation/release-pom.xml module/release-pom.xml 
> module/advertising/release-pom.xml module/buttonconfig/release-pom.xml 
> module/core/release-pom.xml module/film/release-pom.xml 
> module/profile/release-pom.xml module/proxy/release-pom.xml 
> module/rental/release-pom.xml module/service/release-pom.xml 
> module/smartcard/release-pom.xml module/telephony/release-pom.xml 
> module/terminalui/release-pom.xml module/tv/release-pom.xml 
> module/upsell/release-pom.xml module/urlconfig/release-pom.xml 
> mule/release-pom.xml mule/advertising/release-pom.xml 
> mule/button-config/release-pom.xml mule/film/release-pom.xml 
> mule/hospediacard/release-pom.xml mule/location/release-pom.xml 
> mule/profile/release-pom.xml mule/proxy/release-pom.xml 
> mule/rental/release-pom.xml mule/service/release-pom.xml 
> mule/smartcard/release-pom.xml mule/startup/release-pom.xml 
> mule/terminaluimenu/release-pom.xml mule/tv/release-pom.xml 
> mule/upsell/release-pom.xml mule/urlconfig/release-pom.xml
> {noformat}
> This doesn't work for my setup because each directory is a git submodule so 
> must be run separately, it looks to me like it's simply ignoring the 
> {{commitByProject}} setting, but the docs 
> (http://maven.apache.org/plugins/maven-release-plugin/prepare-with-pom-mojo.html)
>  list it as being a supported property since {{2.0-beta5}}.  I've marked this 
> as a blocker because I wanted to use the release-pom.xml and I have no way to 
> generate them now (since the {{-DgenerateReleasePoms}} option on the 
> {{release:prepare}} goal seems to have been deprecated).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to