[ 
https://jira.codehaus.org/browse/MCHANGELOG-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=305075#comment-305075
 ] 

Samuel Van Reeth edited comment on MCHANGELOG-108 at 7/31/12 11:35 AM:
-----------------------------------------------------------------------

Current behaviour:
the xml is created with attributes "startVersion" and "endVersion" on element 
changeset (ChangeLogSet, maven-scm-api dependency), but when reading the xml, 
the code (ChangelogHandler.java) looks for attributes "startTag" and "endTag", 
finding no such attributes.
This results in a report with headers "Changes since project creation" rather 
than expected "Changes between...".

Fix in ChangelogHandler:
use "startVersion" and "endVersion" instead of "startTag" and "endTag" (see 
patch file)
                
      was (Author: rodikal):
    Current behaviour:
the xml is created with attributes "startVersion" and "endVersion" on element 
changeset (ChangeLogSet, maven-scm-api dependency), but when reading the xml, 
the code (ChangelogHandler.java) looks for attributes "startTag" and "endTag", 
finding no such attributes.
This results in a report with headers "Changes since project creation" rather 
than expected "Changes between...".

Fix in ChangelogHandler:
use "startVersion" and "endVersion" instead of "startTag" and "endTag"
                  
> read/write changelog.xml inconsistency
> --------------------------------------
>
>                 Key: MCHANGELOG-108
>                 URL: https://jira.codehaus.org/browse/MCHANGELOG-108
>             Project: Maven 2.x Changelog Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1
>            Reporter: Grzegorz Kochanski
>            Priority: Minor
>         Attachments: MCHANGELOG-108-useTagNamesFromChangeLogSetClass.patch
>
>
> ChangelogHandler.java:165
>             bufSet.setStartVersion(new 
> ScmTag(attributes.getValue("startTag")));
>             bufSet.setEndVersion(new ScmTag(attributes.getValue("endTag")));
> ChangeLogSet.java:180
>         if ( startVersion != null )
>         {
>             buffer.append( " startVersion=\"" )
>                 .append( getStartVersion() )
>                 .append( "\"" );
>         }
>         if ( endVersion != null )
>         {
>             buffer.append( " endVersion=\"" )
>                 .append( getEndVersion() )
>                 .append( "\"" );
>         }
> Please fix field name to startVersion/endVersion.
> When changelog.xml is present then settings like: type, range, dates should 
> be taken from this file during repoprt generation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to